Code:
Name: LRP - Duddino
Term: 1 Cycle
Cycle Amount: 10,000
Total Amount: 10,000
Author: Duddino, JSKitty
Receiver: Duddino
Address: DShxa9sykpVUYBe2VKZfq9dzE8f2yBbtmg
Created: 18-06-2024
Status: Active
Vote Hash: 995ee7c80561480f7a3548eb375db770d202f5aac6197040a83c9359324597fcThis is a continuation of my previous proposals, the last one being here.
Returning Note
As you may have noticed, there was no proposal from me for the month of June.
This is because, as announced in the previous thread, I decided to take a summer vacation in the month of June instead of August like I did last year.
Due to unexpected circumtansces, I wasn't able to return to work on the first of July. Instead, I started on Monday 15th. Because of this, and because I might be taking a few days off to finish some business in my personal life (Specifically Friday 19 and Monday 22), I will be asking for 10000 PIV for this month of July.
Starting from August, I continue making my regular proposals, but I will not make another progress report, due to the short amount of time between the two.
MPW work
These months were focused on optimizing MPW, specifically for those with a slow connection.
The main bundle size, was cut down from 455KB to 325KB, a ~28% reduction in size. This was achieved with the following PRs:
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/355 Minimize `countries.json`
We use `country-locale-map` to auto-detect currencies based on the user's language. However, this brings a lot of useless data, this PR tells webpack to include just the data we need.
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/366 Use `countries.json` directly instead of the provided functions to skip some of the imports
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/360 Polyfill `crypto` with noble
Quite a few dependencies depended on the `crypto` library, but we already had a `noble` library available. This PR replaces `crypto` with `noble`.
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/367 Polyfill all the `secp256k1` with `@noble/secp256k1`.
A in house replacement was made for `secp256k1-noble`, and tested using the same tests for the original library, which can be found here https://github.com/PIVX-Labs/secp256k1-noble
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/365 Cache and prefetch shield files.
This removes a bunch of initial download time because each shield helper script was previously fetched once per core each time MPW was opened. This not only makes it effectively fetch it one time, it also caches it between sessions.
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/313 Update txid in fromHex
This speeds up the calculation of txids, specifically for systems with slow CPUs.
Additionally, a number of improvements were made:
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/369 Auto deshield transactions when sending to a transparent/exchange address, by automatically using a burner transparent address.
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/325 Rewrite stake tab in vue
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/318 Add commit hash to dev builds
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/322 Export extended sapling spending key as well as xpriv
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/336 Resync from scratch if sapling root is different that what's advertised.
This helps in cases where the explorer might fork, previously a manual resync was necessary
And some bug fixes, cleanup and improved test coverage:
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/347 Secret parsing tests
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/353 Wallet composable tests
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/368 Fix undefined alerts when locale is missing
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/359 Fix spending txs with shield data on ledger
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/354 Various shield fixes
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/339 Fix change password
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/338 Cleanup some legacy modal functions
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/329 Fix promo code creation
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/327 Allow wallet deletion if syncing failed
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/319 Fix ledger masternode creation
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/312 Fix eslint warnings
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/308 Always restore wallet instead of alerting
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/304 Fix negative number balances
Blockbook Explorer work
- https://github.com/PIVX-Project/PIVX-BlockExplorer/pull/1 Exchange address support
- https://github.com/PIVX-Project/PIVX-BlockExplorer/pull/2 Add getBlock websocket endpoint
PIVX Shield library
- https://github.com/PIVX-Labs/pivx-shield/pull/84 Add tag to makefile for release
- https://github.com/PIVX-Labs/pivx-shield/pull/83 Add `getSaplingRoot` and `reloadFromCheckpoint`, needed for MyPIVXWallet/326
Last edited: