Code:
Name: LRP - Duddino
Term: 3 Cycles
Cycle Amount: 30,000
Total Amount: 90,000
Author: Duddino, JSKitty
Receiver: Duddino
Address: DShxa9sykpVUYBe2VKZfq9dzE8f2yBbtmg
Created: 11-12-2023
Status: Active
Vote Hash: cf73526a3c325eaa121d076615d044cdbf7456b303db76b6e923da0d9a31f210This is a continuation of my previous proposals, the last one being here.
MPW Shield
A new shield PR was opened and more progress has been made over on the library.
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/244 - Shield support to MPW. Co-authored with Alessandro.
- https://github.com/PIVX-Labs/pivx-shield/pull/66 - Fix of the build, which failed due to dependency changes upstream.
- https://github.com/PIVX-Labs/pivx-shield/pull/67 - Rewrite the JavaScript part to TypeScript, which included a couple of bug fixes. This triggered the 1.1.0 version.
- https://github.com/PIVX-Labs/pivx-shield/pull/70 - Automatically build the library to Web-Assembly and upload of the two versions (single and multi-core) to GitHub. Anyone can now verify that the version published to npm actually matches up with the one build from source on GitHub and that no one has tampered with the Web Assembly (This will happen as soon as the next release hits and before the release of shield on MPW stable. 1.1.1 has been built locally on Alessandro's machine.)
- https://github.com/PIVX-Labs/pivx-shield/pull/73 - Fix single core never finishing the transaction.
The other minor PRs can be seen on GitHub at URL: https://github.com/PIVX-Labs/pivx-shield/pulls?q=is
r+author:duddinoOther MPW Work
As MPW continues to mature, the focus has gradually shifted from creating new features to emphasizing the assurance of its existing framework with automated tests and porting legacy code to Vue.
Vue port:
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/204 - Port wallet balance GUI to Vue
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/225 - Port the entire dashboard tab. This splits the dashboard in 10 components. I decided to make a bigger PR instead of what would have been 9 smaller ones, as it allowed me to make use of a lot of the Vue features to make the components talk to each other.
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/271 - This picks up the work from the previous #225 and splits delegates the duty of talking to the logic part of MPW to a composable.
The jest test framework was added, which was later changed to vitest, mainly because it has support for ES6 modules outside of the box.
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/216 Add the jest framework (+ masterkey tests)
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/264 Switch to vitest (+ transfer menu test)
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/278 Add istanbul test coverage
Other work and bug fixes include:
- Setting up automatic deploys using netlify (No PR associated because it's a GitHub app)
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/209 - Fix activity spam
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/214 - Load languages lazily instead of always
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/218 - Refactor ledger to rely less on the USB connection, this removes a lot of the edge cases and makes it less prone to bugs
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/220 - Add my own instance of the testnet explorer
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/222 - Fix identicon being squished
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/224 - Add a better error if you forget to add the ledger udev rules on a linux machine
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/229 - 1.3.0 prerelease bug fixes
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/239 - Fix github actions not working in forks
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/241 - Add python scripts to quickly manage all of our language files
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/245 - Fix txdb not deleting testnet txs
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/246 - Implement change addresses
- https://github.com/PIVX-Labs/MyPIVXWallet/pull/255 - Automatically detect currency based on user locale
- #260, #261, #262, #265, #278, various bug fixes.
A complete list of all the MPW PRs can be seen at https://github.com/PIVX-Labs/MyPIVXWallet/pulls?q=+is
r+author:duddino
Last edited:
